Skip to content

fix: errors in CI, turbo config for navigation package, ENOSPC in CI, upload Detox recordings#387

Open
artus9033 wants to merge 7 commits into
mainfrom
fix/navigation-turbo-cache-issue
Open

fix: errors in CI, turbo config for navigation package, ENOSPC in CI, upload Detox recordings#387
artus9033 wants to merge 7 commits into
mainfrom
fix/navigation-turbo-cache-issue

Conversation

@artus9033

@artus9033 artus9033 commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

CI fixes

  • brownfield-navigation Turbo config — turbo.json with lib/** outputs so Turbo cache restores build artifacts (fixes Metro missing NativeBrownfieldNavigation on faulty cache hit).
  • Turbo inputs — package turbo.json files include bob/babel/tsconfig config as build inputs.

Android CI

  • gradle/actions/setup-gradle replaces manual actions/cache on ~/.gradle.
  • Per-app Gradle cache via workflow-job-context (flavor: vanilla, expo54, etc.).
  • Skip duplicate yarn build in prepare-android when setup already ran.
  • ENOSPC prevention - rm RN Android build dirs before AndroidApp assemble

iOS E2E

  • Detox testTimeout raised from 180s → 300s, which was flaky due to full restart between cases.
  • Upload Detox recordings as artifacts.

Test plan

CI green.

@artus9033 artus9033 self-assigned this Jun 18, 2026
Copilot AI review requested due to automatic review settings June 18, 2026 15:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing Turborepo task configuration for @callstack/brownfield-navigation so CI caching correctly captures the package’s build artifacts instead of potentially restoring an incomplete cache.

Changes:

  • Add packages/brownfield-navigation/turbo.json to declare build task inputs/outputs (lib/**).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +5 to +8
"build": {
"inputs": ["src/**/*"],
"outputs": ["lib/**"]
}
@artus9033 artus9033 requested a review from hurali97 June 18, 2026 16:03
@artus9033 artus9033 force-pushed the fix/navigation-turbo-cache-issue branch from c010d2b to 301c749 Compare June 18, 2026 17:40
@artus9033 artus9033 changed the title fix: add turbo configuration to brownfield-navigation to fix CI errors - navigation build artifacts fix: errors in CI, turbo config for navigation package, ENOSPC in CI Jun 18, 2026
@artus9033 artus9033 force-pushed the fix/navigation-turbo-cache-issue branch from 4cef4b4 to 5789ff7 Compare June 19, 2026 00:27

@hurali97 hurali97 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think if we need to run changeset for these changes as they are not user facing?

@artus9033

Copy link
Copy Markdown
Collaborator Author

Do you think if we need to run changeset for these changes as they are not user facing?

I'd say we don't need to. It would appear in the changelogs, which we don't want.

@artus9033 artus9033 changed the title fix: errors in CI, turbo config for navigation package, ENOSPC in CI fix: errors in CI, turbo config for navigation package, ENOSPC in CI, upload Detox recordings Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants